random: Make php_random_bytes() useable early during engine startup
#14291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeriyoshi
approved these changes
May 22, 2024
This variant can be used before RANDOM_G() is initialized
arnaud-lb
force-pushed
the
get-random-atomic
branch
from
d03040d to
3874016
Compare
TimWolla
requested changes
May 30, 2024
TimWolla
approved these changes
May 30, 2024
TimWolla
changed the title
php_random_bytes() useable early during engine startupphp_random_bytes() useable early during engine startup
|
Thank you @morrisonlevi @TimWolla @zeriyoshi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php_random_bytes()uses some thread-specific state and can not be used too early. In this PR I refactor it so that is uses a true global instead.I also introduce
php_random_bytes_ex(), with a slightly different API that can expose errors without throwing exceptions.This is a dependency of #14054.